[Bug-tar] Compilation/configuration errors with tar-1.15

[Jim Reid]

configure sems to do its job OK after I unpack the tarball on my MacOSX 
10.3.8 and BSD/OS4.2 boxes.

However  the compilations fail with the same error. On MacOSX:

% make -k
make  all-recursive
Making all in doc
make[2]: Nothing to be done for `all'.
Making all in lib
make  all-am
make[3]: Nothing to be done for `all-am'.
Making all in rmt
make[2]: Nothing to be done for `all'.
Making all in src
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib -I../ -I../lib     -g -O2 
-MT tar.o -MD -MP -MF ".deps/tar.Tpo" -c -o tar.o tar.c; \
then mv -f ".deps/tar.Tpo" ".deps/tar.Po"; else rm -f ".deps/tar.Tpo"; 
exit 1; fi
tar.c: In function `main':
tar.c:1624: error: `LC_ALL' undeclared (first use in this function)
tar.c:1624: error: (Each undeclared identifier is reported only once
tar.c:1624: error: for each function it appears in.)
make[2]: *** [tar.o] Error 1
make[2]: Target `all' not remade because of errors.
Making all in scripts
make[2]: Nothing to be done for `all'.
Making all in po
make[2]: Nothing to be done for `all'.
Making all in tests
make[2]: Nothing to be done for `all'.
make[2]: Nothing to be done for `all-am'.
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


On BSD/OS 4.2:

% make -k
make  all-recursive
Making all in doc
Making all in lib
make  all-am
Making all in rmt
source='rmt.c' object='rmt.o' libtool=no  DEPDIR=.deps depmode=gcc 
/bin/bash ../config/depcomp  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib 
-I../ -I../lib     -g -O2 -c rmt.c
rmt.c: In function `main':
rmt.c:284: `LC_ALL' undeclared (first use in this function)
rmt.c:284: (Each undeclared identifier is reported only once
rmt.c:284: for each function it appears in.)
rmt.c:288: warning: passing arg 2 of `rpl_getopt_long' discards 
qualifiers from pointer target type
*** Error code 1 (continuing)
`all' not remade because of errors.
Making all in src
source='tar.c' object='tar.o' libtool=no  DEPDIR=.deps depmode=gcc 
/bin/bash ../config/depcomp  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib 
-I../ -I../lib     -g -O2 -c tar.c
tar.c: In function `main':
tar.c:1624: `LC_ALL' undeclared (first use in this function)
tar.c:1624: (Each undeclared identifier is reported only once
tar.c:1624: for each function it appears in.)
*** Error code 1 (continuing)
`all' not remade because of errors.
Making all in scripts
Making all in po
Making all in tests

It looks to me that configure hasn't done the Right Thing after it's 
found <locale.h>.
This didn't happen with the previous release. Any suggestions?


BTW, it would also be *very* nice if GNU tar used SSH instead of rsh as 
the remote shell.
rsync does this by default now. Besides, nobody should be using rsh 
anyway.