bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-tar] paxutils/tests/genfile.c lint removal


From: Paul Eggert
Subject: [Bug-tar] paxutils/tests/genfile.c lint removal
Date: Mon, 07 Aug 2006 14:36:51 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

I installed this to fix some warnings with GCC 4.1.1:

2006-08-07  Paul Eggert  <address@hidden>

        * tests/genfile.c (reg_action): Return void, not int.
        (generate_simple_file, exec_command): Remove unused var.
        (print_stat): Avoid GCC warning about uninitialized var.

--- tests/genfile.c     3 Jul 2006 17:06:53 -0000       1.18
+++ tests/genfile.c     7 Aug 2006 21:34:05 -0000
@@ -278,7 +278,7 @@ struct action
 
 static struct action *action_list;
 
-int
+void
 reg_action (int action, char *arg)
 {
   struct action *act = xmalloc (sizeof (*act));
@@ -402,7 +402,6 @@ fill (FILE *fp, off_t length, enum patte
 static void
 generate_simple_file (char *filename)
 {
-  int i;
   FILE *fp;
 
   if (filename)
@@ -559,7 +558,7 @@ print_stat (const char *name)
        printf ("%lu", (unsigned long) st.st_ino);
       else if (strncmp (p, "mode", 4) == 0)
        {
-         mode_t mask;
+         mode_t mask = ~0;
 
          if (ispunct (p[4]))
            {
@@ -572,9 +571,7 @@ print_stat (const char *name)
                  error (EXIT_FAILURE, 0, _("incorrect mask (near `%s')"), q);
                }
            }
-         else if (!p[4])
-           mask = ~0;
-         else
+         else if (p[4])
            {
              printf ("\n");
              error (EXIT_FAILURE, 0, _("Unknown field `%s'"), p);
@@ -710,7 +707,7 @@ process_checkpoint (size_t n)
 void
 exec_command (void)
 {
-  int i, status;
+  int status;
   pid_t pid;
   int fd[2];
   char *p;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]