Re: [Bug-tar] error handling and exit code (patch for tar-1.20/1.21)

[Sergey Poznyakoff]

Solar Designer <address@hidden> ha escrit:

>  26: restoring mode on existing directory            FAILED (extrac08.at:36)

Yes, this testcase should set umask.

> Then, test 38 fails intermittently.  It appears to be more likely to fail
> during the first build on a system than during subsequent rebuilds.  In
> the diffs, I see:

There is a race condition in the test. I'll fix it.

> Finally, as it relates to the tests, it was reported to me that test 12
> fails on some systems (where all other tests pass):
> 
>  12: transforming hard links on create               FAILED (xform-h.at:39)

What systems are these? Perhaps they don't support hard links at all?

>   char *dirp = savedir (dir);   /* for scanning directory */
> [...]
>   if (! dirp)
>     savedir_error (dir);
> 
> Perhaps we need to patch this in our usual way?

Looks reasonable. I'll see what can be done.

Regards,
Sergey