Re: [Bug-tar] error handling and exit code (patch for tar-1.20/1.21)

[Dmitry V. Levin]

On Tue, Aug 25, 2009 at 04:50:09PM +0400, Dmitry V. Levin wrote:
> On Tue, Aug 25, 2009 at 10:37:13AM +0300, Sergey Poznyakoff wrote:
> > Solar Designer ha escrit:
> > 
> > >  26: restoring mode on existing directory            FAILED 
> > > (extrac08.at:36)
> > 
> > Yes, this testcase should set umask.
> > 
> > > Then, test 38 fails intermittently.  It appears to be more likely to fail
> > > during the first build on a system than during subsequent rebuilds.  In
> > > the diffs, I see:
> > 
> > There is a race condition in the test. I'll fix it.
> > 
> > > Finally, as it relates to the tests, it was reported to me that test 12
> > > fails on some systems (where all other tests pass):
> > > 
> > >  12: transforming hard links on create               FAILED 
> > > (xform-h.at:39)
> > 
> > What systems are these? Perhaps they don't support hard links at all?
> 
> This test appears to be sensitive to file names order: if
> "ls -U basedir" outputs "test test_link", then xform-h.at works,
> otherwise, if it outputs "test_link test", then this test fails.

Proposed fix:

--- a/tar/tests/xform-h.at
+++ b/tar/tests/xform-h.at
@@ -32,7 +32,7 @@ AT_KEYWORDS([transform xform xform-h])
 
 m4_define([xform],[
 echo "$1"
-tar cf archive --transform="s,^basedir/,,$2" basedir
+tar cf archive --transform="s,^basedir/,,$2" basedir/*
 tar tvf archive | sed -n 's/.*test_link link to //p'
 ])
 

-- 
ldv

pgphl_rJKB5l8.pgp
Description: PGP signature