Re: [Bug-tar] segfault getting cwd with --listed-incremental

[Sergey Poznyakoff]

Paul Eggert <address@hidden> ha escrit:

> I haven't a clue.  Let's remove that.  I tried doing that in the patch
> enclosed below, which I installed.  Sergey, can you please
> double-check this?

I quite agree with the patch to extract_dir.  However, I don't agree
with the patch to normalize_filename_x.  This function must produce an
absolute file name corresponding to the given relative one,
*without* taking into account any symbolic links, so that the
proposed patch simply breaks it.  The function is not intended to
resolve symbolic links, quite on the contrary, it was introduced instead
of canonicalize_file_name which, by doing so, broke the
`--remove-file' functionality in some cases (see the commit message for
c1d3d134939d).

> Anyway, the patched version passes the tests so if there is
> some reason the path names have to be absolute, that should be tested
> for.

Agreed, the test suite should be more thorough.

Regards,
Sergey