Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

[Joerg Schilling]

Andreas Dilger <address@hidden> wrote:

> That means SEEK_HOLE is NOT available in RHEL 6.x kernels, which are still
> in fairly widespread (though declining) use.  I'd prefer that the heuristic
> for sparse files without SEEK_HOLE not be removed completely, but I do think
> that it needs to be fixed for the small inline file and file in cache cases.

While you should always be prepared to find historic filesystems and do 
something reasonable with then...

SEEK_HOLE was first implemented 13 years ago and after that amount of time, 
implementors should be allowed to assume that any halfway up to date system now 
supports it.

Jörg

-- 
 EMail:address@hidden                    (home) Jörg Schilling D-13353 Berlin
    address@hidden (work) Blog: http://schily.blogspot.com/
 URL: http://cdrecord.org/private/ http://sf.net/projects/schilytools/files/'