[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only
From: |
Mark H Weaver |
Subject: |
Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes |
Date: |
Tue, 23 Jan 2018 03:44:25 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi Andreas,
Andreas Dilger <address@hidden> writes:
> On Jan 20, 2018, at 5:06 PM, Mark H Weaver <address@hidden> wrote:
>> Yes, on Btrfs I reliably see (st_blocks == 0) on a recently written,
>> mostly sparse file with size > 8G, using linux-libre-4.14.14. More
>> specifically, the "storing sparse files > 8G" test in tar's test suite
>> reliably fails on my system:
>>
>> 140: storing sparse files > 8G FAILED (sparse03.at:29)
>
> I'd consider this a bug in Btrfs.
On what basis? Can you formulate a precise rule regarding 'st_blocks'
that is worth defending, that would enable this optimization, and that
Btrfs is violating here?
> As mentioned previously, we had the same problem with ext4 (twice) and
> Lustre, and in both cases fixed this by adding in the (dirty page
> cache pages/512) if the current block count is zero:
Would you like to propose a fix to the Btrfs developers?
Mark
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, (continued)
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Joerg Schilling, 2018/01/19
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Andreas Dilger, 2018/01/17
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Joerg Schilling, 2018/01/18
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Mark H Weaver, 2018/01/20
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Joerg Schilling, 2018/01/22
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Mark H Weaver, 2018/01/23
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Joerg Schilling, 2018/01/23
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Mark H Weaver, 2018/01/23
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Andreas Dilger, 2018/01/23
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Andreas Dilger, 2018/01/22
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes,
Mark H Weaver <=
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Andreas Dilger, 2018/01/23
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Mark H Weaver, 2018/01/24
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Ralph Corderoy, 2018/01/24
- Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes, Andreas Dilger, 2018/01/25
Re: [Bug-tar] Detection of sparse files is broken on btrfs, Joerg Schilling, 2018/01/08
Re: [Bug-tar] Detection of sparse files is broken on btrfs, Mark H Weaver, 2018/01/08