bug-xboard
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-XBoard] [bug #39971] fix configure switches misbehaving


From: h . g . muller
Subject: Re: [Bug-XBoard] [bug #39971] fix configure switches misbehaving
Date: Sat, 7 Sep 2013 13:50:37 +0200
User-agent: SquirrelMail

Hmm, I guess this is something that crept in unintentially long ago.
XBoard was always designed so that it also could use bitmap pieces if
libXpm was not available. The pieces are now completely the responsibilty
of Cairo, however.

XBoard uses a few black-and-white pixmaps unconditionally for the icons in
the headers of the panes in the Engine Output window, though. I suppose
this (i.e. setting the XtNleftBitmap in DrawWidgetIcon()) could also have
been done with bitmaps. At least, we seem to do that for the checkmarking
of menu items, albeit in a fishy way. (The file with the check-mark image
is a bm file and read by ReadBitmap, but it is assigned to a variable
declared as Pixmap).

So perhaps it would be better to convert these 7 remaining pixmaps to
bitmaps, and also use ReadBitmap in ReadIcon (xengineoutput.c) to read
them, to make XBoard truly xpm-independent? Unlike with the pieces in the
pre-Cairo era, the use of pixmaps has no advantage at all here, as the
icons are all monochrome (and should be, to be accepted as XtNleftBitmap).

The remaing xpm files in the pixmaps directory of the source tree are
desktop icons for file associations not accessed directly by XBoard
itself. Would it be better to convert those to PNG?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]