Re: [Bug-XBoard] [bug #39971] fix configure switches misbehaving

[hasufell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/07/2013 01:50 PM, address@hidden wrote:
> Hmm, I guess this is something that crept in unintentially long
> ago. XBoard was always designed so that it also could use bitmap
> pieces if libXpm was not available. The pieces are now completely
> the responsibilty of Cairo, however.
> 
> XBoard uses a few black-and-white pixmaps unconditionally for the
> icons in the headers of the panes in the Engine Output window,
> though. I suppose this (i.e. setting the XtNleftBitmap in
> DrawWidgetIcon()) could also have been done with bitmaps. At least,
> we seem to do that for the checkmarking of menu items, albeit in a
> fishy way. (The file with the check-mark image is a bm file and
> read by ReadBitmap, but it is assigned to a variable declared as
> Pixmap).
> 
> So perhaps it would be better to convert these 7 remaining pixmaps
> to bitmaps, and also use ReadBitmap in ReadIcon (xengineoutput.c)
> to read them, to make XBoard truly xpm-independent? Unlike with the
> pieces in the pre-Cairo era, the use of pixmaps has no advantage at
> all here, as the icons are all monochrome (and should be, to be
> accepted as XtNleftBitmap).
> 
> The remaing xpm files in the pixmaps directory of the source tree
> are desktop icons for file associations not accessed directly by
> XBoard itself. Would it be better to convert those to PNG?
> 
> 


The freedesktop.org icon theme spec says that xpm is only supported
due to backwards compatibility. So PNG seems more modern.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSKxUIAAoJEFpvPKfnPDWzEt4H/RKciI5SZ8M4to2Ih5Fa7jlM
nHaEe4DZNMQzXyqyskVYFPMzz3cJ7tJ6At1xPyYpJPNElTB69vS5WWHrMZN4d0sJ
v1mmQUhnrnD9LrvLwGXAbzFiWek5LCaU2KAdh3Y4toTl6IFGnRstrP4JeTAEvYg4
Di43i4NWv2p1ivVHO8z2SVNk3Uh0brqSdIbr0PW7i8GOQJFVs5FSTYx5x9Eb48G5
2rbLXp23gwESPzv8G3Ibvcg/gJp/XRgglOe1vF1PBS3Xe7FVWFQmxv7f2mlcjZPk
WgY3S2Y1QDuQ+wtsHm1tIADI9S2n97k8+1YQ5ckW3onO1+evO+Ef9dEcCGLtbZU=
=cNic
-----END PGP SIGNATURE-----