Re: [Chicken-users] [patch] remove the initial check on directory existance

[richo]

On 03/02/13 11:42 +0100, Peter Bex wrote:
> On Sun, Feb 03, 2013 at 06:42:55PM +1100, richo wrote:
> > 3) expose a new function that raises errors if the directory exists so that
> > an atomic mkdir is available. My thought is to just name it mkdir, but I'm
> > not sure where it belongs.
>
> Please don't do that.  This sort of "design" leads to
> mysql_real_escape_string.  It's confusing to the user, and ugly to
> have several differently named procedures that do almost exactly
> the same thing but with slight differences in behavior.
>
> Better to either keep it the way it is, change the semantics and
> breaking compat (so be it), or convert to keyword args and make it an
> optional feature (my least favorite alternative).
>
> Cheers,
> Peter

Awesome,

I guess with that said, I need someone who's more planted in the project to
make a call so I know which way to jump. My preference is certainly to change
the semantics and have a unified implementation without weird caveats, but I
can't speak for how much code it'll break.

I have a patch ready, but I can't test it as I can't get the test suite to
work (followup post to -hackers incoming)

Thanks again

Richo

--
richo || Today's excuse:

The Dilithium Crystals need to be rotated.
http://blog.psych0tik.net

signature.asc
Description: Digital signature