[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] Patch proposal: gnu.java.nio.PipeImpl
From: |
Michael Koch |
Subject: |
Re: [cp-patches] Patch proposal: gnu.java.nio.PipeImpl |
Date: |
Wed, 21 Jul 2004 12:58:43 +0200 |
User-agent: |
KMail/1.6.2 |
Am Montag, 19. Juli 2004 22:20 schrieb Patrik Reali:
> Hi!
>
> I propose the attached patch to move the native method "nativeInit"
> out of gnu/java/nio/PipeImpl.java into
> vm/reference/gnu/java/nio/VMPipeImpl.java (method "init"). The
> patch also updates the jni code. (I never thought moving one single
> method would change so many files!)
>
> Not very fancy, but with the potential to upset all the VM
> maintainers with a new class....
I should have said this earlier but somehow it jsut shot into my head:
VMPipeImpl is a bad name. Please rename this to VMPipe. This is clear
enough. We dont need the "Impl"-suffix for "VM" classes.
Michael