RE: [cp-patches] Patch proposal: gnu.java.nio.PipeImpl

[Jeroen Frijters]

Hi Patrik, 

I apologize for not noticing this earlier, but IMO VMPipeImpl was in
fact the correct name. I disagree strongly with Michael, because I think
that the VM classes should always have the exact same name as the class
they correspond with (in this PipeImpl) plus the VM prefix.

Regards,
Jeroen

> -----Original Message-----
> From: address@hidden 
> [mailto:address@hidden 
> On Behalf Of Patrik Reali
> Sent: Wednesday, July 21, 2004 22:37
> To: Michael Koch; address@hidden
> Cc: Ewout Prangsma
> Subject: Re: [cp-patches] Patch proposal: gnu.java.nio.PipeImpl
> 
> OK, the commit is on its way to the gnu server....
> 
> -Patrik
> 
> 
> 
> --On Mittwoch, 21. Juli 2004 12:58 +0200 Michael Koch 
> <address@hidden> 
> wrote:
> 
> > Am Montag, 19. Juli 2004 22:20 schrieb Patrik Reali:
> >> Hi!
> >>
> >> I propose the attached patch to move the native method "nativeInit"
> >> out of gnu/java/nio/PipeImpl.java into
> >> vm/reference/gnu/java/nio/VMPipeImpl.java (method "init"). The
> >> patch also updates the jni code. (I never thought moving one single
> >> method would change so many files!)
> >>
> >> Not very fancy, but with the potential to upset all the VM
> >> maintainers with a new class....
> >
> > I should have said this earlier but somehow it jsut shot 
> into my head:
> > VMPipeImpl is a bad name. Please rename this to VMPipe. 
> This is clear
> > enough. We dont need the "Impl"-suffix for "VM" classes.
> >
> >
> > Michael
> 
> 
> 
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches
>