[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] Re: http.agent patch
From: |
Mark Wielaard |
Subject: |
[cp-patches] Re: http.agent patch |
Date: |
Fri, 23 Jul 2004 13:30:00 +0200 |
Hi (moved to classpath-patches from commit-classpath),
On Sun, 2004-07-11 at 22:58, Michael Koch wrote:
> Am Sonntag, 11. Juli 2004 22:47 schrieb Mark Wielaard:
> > 2004-07-11 Mark Wielaard <address@hidden>
> >
> > * java/lang/System.java (static): Set http.agent system
> > property when not yet set.
> > * gnu/java/net/protocol/http/Connection.java (static): Get
> > httpAgent from system property inside
> > AccessController.doPrivileged() call.
> >
> > Sorry for not handling this before 0.10 got released.
> > OK to commit?
>
> I like it. I just don't get why you remove the "private" here:
>
> - - private static int proxyPort = 80;
> - - private static boolean proxyInUse = false;
> - - private static String proxyHost = null;
> - -
> - - private static final String userAgent;
> +
> + // Properties depeending on system properties settings
> + static int proxyPort = 80;
> + static boolean proxyInUse = false;
> + static String proxyHost = null;
> + static String userAgent;
>
> Perhaps to much beer today ...
No good catch. I'll add it to the ChangeLog entry.
Since we now use an inner class I made them package private so
traditional byte code compilers don't need to insert new accessor
methods to get/set these values.
2004-07-23 Mark Wielaard <address@hidden>
* java/lang/System.java (static): Set http.agent system
property when not yet set.
* gnu/java/net/protocol/http/Connection.java (static): Get
httpAgent from system property inside AccessController.doPrivileged()
call.
(proxyPort): Made package private.
(proxyInUse): Likewise.
(proxyHost): Likewise.
(userAgent): Likewise.
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [cp-patches] Re: http.agent patch,
Mark Wielaard <=