classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [cp-patches] Path proposal: java.io.PrintStream


From: Jeroen Frijters
Subject: RE: [cp-patches] Path proposal: java.io.PrintStream
Date: Sat, 24 Jul 2004 11:03:09 +0200

Bryce McKinlay wrote:
> Jeroen Frijters wrote:
> 
> >The attached patch fixes PrintStream to allow subclassing to work as
> >expected (and allows the Mauve PrintStream.subclass test to pass).
> >  
> >
> It seems inefficient to add yet another indirection layer. I think a 
> better solution would be to make the classpath PrintStream 
> more like the libgcj implementation, which uses the character
> converter directly instead of depending on
> PrintWriter/OutputStreamWriter.

I agree it isn't ideal. I wasn't even aware that libgcj had a different
implementation (sigh, why is there still so much non-essential
divergence?).

I still want to commit my patch because I don't think the additional
overhead is too big compared with the existing implementation. Hopefully
one day someone will merge the libgcj version.

Regards,
Jeroen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]