RE: [cp-patches] Path proposal: java.io.PrintStream

[Jeroen Frijters]

Bryce McKinlay wrote:
> The problem with PrintStream is that the underlying character 
> converters have not yet been merged. There was talk in the past of 
> making these use the java.nio character APIs, but I now think that is 
> the wrong approach, because those APIs are too heavy-weight 
> and complex for our purposes - we don't want to have to do things in
> terms of nio Buffers from the stream and writer classes. Instead, I
> think the encoding APIs in libgcj and classpath should be merged, 
> keeping them as simple and efficient as possible. The java.nio.charset

> implementations could then be written to use the underlying classpath
> encoder API.

Agreed. That makes more sense.

> > I still want to commit my patch because I don't think the additional
> > overhead is too big compared with the existing implementation. 
> > Hopefully
> > one day someone will merge the libgcj version.
> 
> OK by me, but please add a comment explaining why the wrapper is 
> necessary, and a FIXME explaining that it should go away in 
> the future.

Thanks. Attached is a new version of the patch that includes your
suggestions and also the re-interrupting that I noticed in libgcj's
version.

If nobody objects, I'll commit this tomorrow.

Regards,
Jeroen

PrintStream.patch
Description: PrintStream.patch