Re: [cp-patches] Speed up java.nio.ByteBuffer

[Florian Weimer]

* Tom Tromey:

> Florian> Further improvements will require a new class for a read-only
> Florian> byte buffer, so that the read-only flag can go.
>
> It would be nice to hear what performance impact this has.

Just very little, less than two percent it seems.  It'll take a bit
more time until I reach this part of the profile.

> Florian> 2004-08-12  Florian Weimer  <address@hidden>
> Florian>      * java/nio/ByteBufferImpl.java (put): New methods to speed up
> Florian>      ByteBuffer put and array put operations.
>
> Do we want/need similar changes to all the other *BufferImpl
> classes?

I'm not sure if these classes are used at all in real code. 8-)

> I hate to mention this, but would it make sense to generate these
> classes by running sed on a template file, or something similar?  It
> seems strange to keep patching 7 copies of the same code.

IIRC, the ByteBuffer class has got a few additional methods, but the
others could probably be unified.