[cp-patches] Re: Tests for java.awt.Rectangle

[Mark Wielaard]

Hi David,
(Moved from mauve-patches to classpath-patches)

On Thu, 2004-08-12 at 18:39, David Gilbert wrote:
> On Thu, 2004-08-12 at 13:35, Mark Wielaard wrote:
> > Yeah, that was easy to fix. If you don't have a patch yet, I can submit
> > and commit one for GNU Classpath.
> 
> It's probably quicker for you to do the patch, and I'll carry on writing
> tests for now.

OK.

2004-08-14  Mark Wielaard  <address@hidden>

       * java/lang/Rectangle.java (intersects): Check r.width and r.height
       first.

Committed. Now we have only PASSes for your java.awt.Rectangle mauve
tests. Thanks again for writing these tests. It is really appreciated.
And it really helps to get a much better view of the robustness of our
implementation.

Cheers,

Mark

--- java/awt/Rectangle.java     3 Feb 2004 17:17:29 -0000       1.11
+++ java/awt/Rectangle.java     14 Aug 2004 11:09:12 -0000
@@ -542,7 +542,7 @@
    */
   public boolean intersects(Rectangle r)
   {
-    return width > 0 && height > 0 && r.width > 0 && r.height > 0
+    return r.width > 0 && r.height > 0 && width > 0 && height > 0
       && r.x < x + width && r.x + r.width > x
       && r.y < y + height && r.y + r.height > y;
   }

signature.asc
Description: This is a digitally signed message part