Re: [cp-patches] JButton patches

[Mark Wielaard]

Hi,

On Thu, 2004-08-19 at 01:19, Andrew John Hughes wrote:
> Attached is a patch to implement the missing constructors
> in JRadioButton, as well as the accessibility classes for
> both JToggleButton and JRadioButton.  Comments, please.

This looks fine to me. Please commit.

>  2004-08-18  Andrew John Hughes  <address@hidden>
>  
> +       * javax/swing/JRadioButton.java, javax/swing/JToggleButton.java,
> +       javax/swing/AbstractButton.java
> +       Implemented additional constructors and accessibility
> +       classes.  Added documentation and fixed a typo in
> +       AbstractButton.

For documentation changes it isn't that important, but when changing
code mention each field/method that is changed. That way people can
quickly grep through the ChangeLog file to find the patches that touched
a particular method.

(Unsubtle hint to Graydon, I kind of assume you normally take care of
reviewing Swing patches since I think you know much more about that area
of the library than I do. But if you don't care I can give my non-expert
opinion anyway. But changes are big that they are mostly about
nitpicking things like how the ChangeLog entry looks...)

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part