classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Geom bugfixes and docs


From: Sven de Marothy
Subject: [cp-patches] Geom bugfixes and docs
Date: Mon, 06 Sep 2004 18:19:32 +0200

Hi, 
here are some images for documentation I left out before.
(Not attached, You can find them at: http://www.qc.physto.se/~sven/Geom
Should be easy enough to review! :-) )

Also, the Arc2D.intersects() missed a case before. 
Now it should work.

David Gilbert's helpful mauve-tests also pointed out the API's
definition of 'insideness' isn't exactly what I'd implemented.
contains() should return true for the upper-left corner of a rectangle,
but not the bottom-right. (I'd done the reverse)
So this updates Area,CubicCurve2D, QuadCurve2D and GeneralPath to
conform with this definition.

He also caught some bugs in Area. It now passes all his tests.

2004-09-06  Sven de Marothy  <address@hidden>
        * java/awt/geom/doc-files/Area-1.png:
        Graphics for Area documentation. New file.

        * java/awt/geom/doc-files/Ellipse-1.png:
        Graphics for Ellipse2D documentation. New file.

        * java/awt/geom/doc-files/GeneralPath-1.png:
        Graphics for GeneralPath documentation. New file.

        * java/awt/geom/Arc2D.java:
        (intersects): Fix: Now checks the arc segment.
        (contains): Cleaned up.

        * java/awt/geom/Area.java:
        (isRectangular): Should return true on an empty path.
        (equals): Check for null.
        (rayIntersects): Fix insideness-test

        * java/awt/geom/CubicCurve2D.java:
        Fix insideness-test
        * java/awt/geom/GeneralPath.java:
        Likewise
        * java/awt/geom/QuadCurve2D.java:
        Likewise

Attachment: geom2.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]