Re: [cp-patches] Geom bugfixes and docs

[Mark Wielaard]

Hi Sven,

On Mon, 2004-09-06 at 18:19, Sven de Marothy wrote:
> Hi, 
> here are some images for documentation I left out before.
> (Not attached, You can find them at: http://www.qc.physto.se/~sven/Geom
> Should be easy enough to review! :-) )

Nice! Now you make me feel guilty for not having worked on image support
for gjdoc... :)

> Also, the Arc2D.intersects() missed a case before. 
> Now it should work.
> 
> David Gilbert's helpful mauve-tests also pointed out the API's
> definition of 'insideness' isn't exactly what I'd implemented.
> contains() should return true for the upper-left corner of a rectangle,
> but not the bottom-right. (I'd done the reverse)
> So this updates Area,CubicCurve2D, QuadCurve2D and GeneralPath to
> conform with this definition.
> 
> He also caught some bugs in Area. It now passes all his tests.

Please feel free to check these in even though we will have a release
soon. The java.awt.geom package is as good as new this release, it fixes
bugs (for which we have test cases!) and I won't probably be able to do
a real release till Thurday anyway. At which time I will certainly
retest everything.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part