Re: [cp-patches] Patch: support for reading directories viaURL.openConnection()

[Michael Koch]

On Thursday 09 September 2004 17:07, Jeroen Frijters wrote:
> Michael Koch wrote:
> > I just commited the attached patch after a long discussion on IRC
> > (greetrings to mjw and bonniot) to fix bug #10282.
>
> Too bad it wasn't on the mailinglist ;-) I'd really like to see the
> static initializer removed, the lineSeparator is only used in an
> uncommon code path, so it's seems like a waste to get it ahead of
> time. Either get it lazily or use an inner class with a static
> initializer.
>
> Static initializers are quite expensive, so we should try to limit
> them as much as reasonable.

What about this patch ?


Michael


2004-09-09  Michael Koch  <address@hidden>

        * gnu/java/net/protocol/file/Connection.java
        (lineSeparator): Made non-final.
        (static): Removed.
        (connect): Initialize lineSeparator lazily. Use ByteArrayInputStream
        instead of StringBufferInputStream.

filedir.diff
Description: Text Data