Re: [cp-patches] Patch: FYI: fix for constructor oddity

[Michael Koch]

On Sunday 19 September 2004 23:51, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <address@hidden> writes:
>
> Mark> Agreed. But now it has a public constructor which means that
> anybody Mark> could make an instance of ProcessThread.
>
> Only people who can access the type, which is private.
> Or perhaps you mean at runtime -- that's true, you could do it via
> reflection.
>
> Mark> So please make this a package
> Mark> local contructor.
>
> Ok.
>
> gcjx has detected a *lot* of problems like this in Classpath.  I
> will probably write a jumbo patch to fix them all.  IMO it should
> be part of our coding standard to avoid this situation.

It's easy to check for such stuff with checkstyle. Its on my list. ;-)


Michael