[cp-patches] Patch: final fields in javax/swing/JInternalFrame.java & javax/swing/plaf/basic/BasicInternalFrameTitlePane.java

[Jeroen Frijters]

Hi,

I made a bunch of fields final, as required per the API spec.

Regards,
Jeroen

2004-09-20  Jeroen Frijters  <address@hidden>

        * javax/swing/JInternalFrame.java
        (CONTENT_PANE_PROPERTY,FRAME_ICON_PROPERTY,GLASS_PANE_PROPERTY,
        IS_CLOSED_PROPERTY,IS_ICON_PROPERTY,IS_MAXIMUM_PROPERTY,
        IS_SELECTED_PROPERTY,LAYERED_PANE_PROPERTY,MENU_BAR_PROPERTY,
        ROOT_PANE_PROPERTY,TITLE_PROPERTY): Made final as per API spec.
        * javax/swing/plaf/basic/BasicInternalFrameTitlePane.java
 
(CLOSE_CMD,ICONIFY_CMD,MAXIMIZE_CMD,MOVE_CMD,RESTORE_CMD,SIZE_CMD):
        Made final as per API spec.

Index: javax/swing/JInternalFrame.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/JInternalFrame.java,v
retrieving revision 1.6
diff -u -r1.6 JInternalFrame.java
--- javax/swing/JInternalFrame.java     30 Jul 2004 20:21:19 -0000
1.6
+++ javax/swing/JInternalFrame.java     19 Sep 2004 09:54:58 -0000
@@ -341,67 +341,67 @@
    * The property fired in a PropertyChangeEvent when the contentPane
property
    * changes.
    */
-  public static String CONTENT_PANE_PROPERTY = "contentPane";
+  public static final String CONTENT_PANE_PROPERTY = "contentPane";
 
   /**
    * The property fired in a PropertyChangeEvent when the frameIcon
property
    * changes.
    */
-  public static String FRAME_ICON_PROPERTY = "frameIcon";
+  public static final String FRAME_ICON_PROPERTY = "frameIcon";
 
   /**
    * The property fired in a PropertyChangeEvent when the glassPane
property
    * changes.
    */
-  public static String GLASS_PANE_PROPERTY = "glassPane";
+  public static final String GLASS_PANE_PROPERTY = "glassPane";
 
   /**
    * The property fired in a PropertyChangeEvent when the closed
property
    * changes.
    */
-  public static String IS_CLOSED_PROPERTY = "closed";
+  public static final String IS_CLOSED_PROPERTY = "closed";
 
   /**
    * The property fired in a PropertyChangeEvent when the icon property
    * changes.
    */
-  public static String IS_ICON_PROPERTY = "icon";
+  public static final String IS_ICON_PROPERTY = "icon";
 
   /**
    * The property fired in a PropertyChangeEvent when the maximum
property
    * changes.
    */
-  public static String IS_MAXIMUM_PROPERTY = "maximum";
+  public static final String IS_MAXIMUM_PROPERTY = "maximum";
 
   /**
    * The property fired in a PropertyChangeEvent when the selected
property
    * changes.
    */
-  public static String IS_SELECTED_PROPERTY = "selected";
+  public static final String IS_SELECTED_PROPERTY = "selected";
 
   /**
    * The property fired in a PropertyChangeEvent when the layeredPane
property
    * changes.
    */
-  public static String LAYERED_PANE_PROPERTY = "layeredPane";
+  public static final String LAYERED_PANE_PROPERTY = "layeredPane";
 
   /**
    * The property fired in a PropertyChangeEvent when the jMenuBar
property
    * changes.
    */
-  public static String MENU_BAR_PROPERTY = "jMenuBar";
+  public static final String MENU_BAR_PROPERTY = "jMenuBar";
 
   /**
    * The property fired in a PropertyChangeEvent when the rootPane
property
    * changes.
    */
-  public static String ROOT_PANE_PROPERTY = "rootPane";
+  public static final String ROOT_PANE_PROPERTY = "rootPane";
 
   /**
    * The property fired in a PropertyChangeEvent when the title
property
    * changes.
    */
-  public static String TITLE_PROPERTY = "title";
+  public static final String TITLE_PROPERTY = "title";
 
   /** Whether the JInternalFrame is closable. */
   protected boolean closable;
Index: javax/swing/plaf/basic/BasicInternalFrameTitlePane.java
===================================================================
RCS file:
/cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicInternalFrameTi
tlePane.java,v
retrieving revision 1.1
diff -u -r1.1 BasicInternalFrameTitlePane.java
--- javax/swing/plaf/basic/BasicInternalFrameTitlePane.java     26 Jun
2004 16:07:02 -0000     1.1
+++ javax/swing/plaf/basic/BasicInternalFrameTitlePane.java     19 Sep
2004 09:55:09 -0000
@@ -439,22 +439,22 @@
   }
 
   /** The action command for the Close action. */
-  protected static String CLOSE_CMD = "Close";
+  protected static final String CLOSE_CMD = "Close";
 
   /** The action command for the Minimize action. */
-  protected static String ICONIFY_CMD = "Minimize";
+  protected static final String ICONIFY_CMD = "Minimize";
 
   /** The action command for the Maximize action. */
-  protected static String MAXIMIZE_CMD = "Maximize";
+  protected static final String MAXIMIZE_CMD = "Maximize";
 
   /** The action command for the Move action. */
-  protected static String MOVE_CMD = "Move";
+  protected static final String MOVE_CMD = "Move";
 
   /** The action command for the Restore action. */
-  protected static String RESTORE_CMD = "Restore";
+  protected static final String RESTORE_CMD = "Restore";
 
   /** The action command for the Size action. */
-  protected static String SIZE_CMD = "Size";
+  protected static final String SIZE_CMD = "Size";
 
   /** The action associated with closing the JInternalFrame. */
   protected Action closeAction;