RE: [cp-patches] Native library class loader fixes

[Jeroen Frijters]

Archie Cobbs wrote:
> Jeroen Frijters wrote:
> > Thanks for this, this is a much needed fix. I'd like to see 
> one change
> > (you knew that was coming, right ;-)): I'd like the new methods
> > getCallingClassLoader() and getCallingClass() to be in a 
> public class
> > gnu.classpath.VMStackWalker (or something like that), so that other
> > packages (most notably java.lang.reflect) can also use 
> these methods.
> 
> I'm happy to do that, but would making those methods public create
> some kind of security hole?

It's the same as with the gnu.classpath.SystemProperties class. Only
trusted code has access to the gnu.classpath.* package (once we have a
working security infrastructure).

> Also, is use of getCallingClass() sufficient for the reflection
> code, or does it really need to "walk" the stack, and therefore need
> getClassContext() too, or some kind of new iterator method?

AFAIK we only need the direct caller, but I haven't worked out the JNI
and reflection scenarios yet.

Regards,
Jeroen