Re: [cp-patches] Native library class loader fixes

[Archie Cobbs]

Jeroen Frijters wrote:
> Thanks. I implemented it with IKVM and it allowed me to remove my own
> stack walking workaround in my JNI code. Everything seems to work.
>
> I made one change to your patch (in loadLibrary in Runtime.java):
> +    else
> +      {
> +       filename = VMRuntime.mapLibraryName(libname);
> +       for (int i = 0; i < libpath.length; i++)
> +         if (loadLib(libpath[i] + filename, null) != 0)
> +           return;
> +      }
>
> I think the second argument to loadLib() should be "loader" instead of
> null. It's a bit counterintuitive, but my understanding is that a native
> library always gets associated with the class loader of the class that
> called loadLibrary (regardless of whether the class loader was otherwise
> involved in finding/loading the library).

You're right.. but in this "else" block it is known that loader == null,
so the effect is the same either way.

> I've also attached a patch for ResourceBundle to use the new
> getCallingClassLoader instead of it having it's own private hack. We
> might be able to get rid of ObjectInputStream.currentClassLoader() as
> well.

Great! More code rendered unnecessary :-) I'll add this to my patch.

Thanks,
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com