classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: Initialise an instances of org.omg.SystemException, th


From: Meskauskas Audrius
Subject: [cp-patches] FYI: Initialise an instances of org.omg.SystemException, thrown due other exception, with InitCause.
Date: Fri, 3 Jun 2005 17:08:02 +0200

Tom Trommey> I think it would be a bit better to just use getMessage
here and add a package-private constructor to allow exception
chaining:

  throw new MARSHAL(ex.getMessage(), ex);
----------------

We cannot use the package private constructor because
the exceptions are thrown from gnu.CORBA and other package
where all our functionality is concentrated. But, indeed, it is a
good suggestion to initialise the cause of the thrown CORBA exception.

I have found another solution: use the public initCause method
before throwing an exception.
Audrius.

* gnu/CORBA/Functional_ORB.java,
gnu/CORBA/IOR_Delegate.java,
gnu/CORBA/Simple_delegate.java,
gnu/CORBA/universalHolder.java,
gnu/CORBA/CDR/aligningInputStream.java,
gnu/CORBA/CDR/aligningOutputStream.java,
gnu/CORBA/CDR/cdrInput.java,
gnu/CORBA/CDR/cdrOutput.java,
gnu/CORBA/CDR/encapsulatedOutput.java,
gnu/CORBA/GIOP/ErrorMessage.java,
gnu/CORBA/GIOP/MessageHeader.java,
gnu/CORBA/GIOP/cxCodeSet.java,
gnu/CORBA/GIOP/v1_2/RequestHeader.java,
org/omg/CosNaming/BindingIteratorHelper.java,
org/omg/CosNaming/BindingListHelper.java,
org/omg/CosNaming/BindingTypeHelper.java,
org/omg/CosNaming/NameComponentHelper.java,
org/omg/CosNaming/NameHelper.java,
org/omg/CosNaming/NamingContextExtHelper.java,
org/omg/CosNaming/NamingContextHelper.java:
Initialise an instances of org.omg.SystemException, thrown due other
exception, with InitCause.

Attachment: Tom.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]