classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Re: [RFA/JDWP] Transport factory


From: Tom Tromey
Subject: [cp-patches] Re: [RFA/JDWP] Transport factory
Date: 03 Jun 2005 14:59:15 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Keith" == Keith Seitz <address@hidden> writes:

Keith> +    IllegalArgumentException e;
Keith> +    e = new IllegalArgumentException ("transport \"" + name + "\" not 
found");
Keith> +    throw new TransportException (e);

It is more ordinary to just make an IllegalArgumentException and throw
it.  Does this need to be caught somewhere else in the JDWP code
somehow?  If so, then wrapping an IllegalArgumentException seems a bit
weird...

Otherwise this looks fine.

Tom




reply via email to

[Prev in Thread] Current Thread [Next in Thread]