classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [cp-patches] FYI: Fixlet for DataInputStream.readLine


From: Roman Kennke
Subject: RE: [cp-patches] FYI: Fixlet for DataInputStream.readLine
Date: Wed, 15 Jun 2005 20:12:53 +0200

Am Mittwoch, den 15.06.2005, 18:00 +0200 schrieb Jeroen Frijters:
> Hi Roman,
> 
> I don't think this is a good idea. It adds a dependency on the internals
> of two other classes and assumes invariants that may not even be true
> (for example, think of subclasses of BufferedInputStream). It also seems
> like it is too complicated for very little gain. Do you have a real
> world scenario where performance is hurt by the previous approach?

No. I just came over this code while merging GNU Classpath with the
Aicas code, where we did even worse stuff at this point. If you think
this is bad, I will reverse my patch. Especially in the light that this
method is deprecated with the statement 'it doesn't work correctly' in
the JDK, this will not matter much anyway.

/Roman






reply via email to

[Prev in Thread] Current Thread [Next in Thread]