classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Fixlet for DataInputStream.readLine


From: Meskauskas Audrius
Subject: Re: [cp-patches] FYI: Fixlet for DataInputStream.readLine
Date: Thu, 16 Jun 2005 11:19:38 +0200

and assumes invariants that may not even be true
(for example, think of subclasses of BufferedInputStream).

Despite the BufferedInputStream does have subclasses in CORBA implementation, and the pos field is accessed in these subclasses, this patch has no effect on they functionality.

From my side, the patch could stay. Setting the pos field to something else
than the position
of the next character is something really tricky; if you think this could really ever happen,
I suggest to use .getClass.equals instead of instanceof.

Audrius.








reply via email to

[Prev in Thread] Current Thread [Next in Thread]