classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: MetalTabbedPaneUI missing functions


From: Thomas Fitzsimmons
Subject: Re: [cp-patches] Patch: MetalTabbedPaneUI missing functions
Date: Tue, 22 Nov 2005 23:14:33 -0500

On Tue, 2005-11-22 at 16:10 -0500, Lillian Angel wrote:
> Added missing functions in MetalTabbedPaneUI. Again, most just call
> super.

If these methods just call super then there's no reason to override
them.  I'm surprised that JAPI is marking these as missing since they
are implemented in the base classes.

Tom

> 
> 2005-11-22  Lillian Angel  <address@hidden>
> 
>         * javax/swing/plaf/metal/MetalTabbedPaneUI.java
>         (getColorForGap): Implemented. Background color is
>         always returned in this case.
>         (paintHighlightBelowTab): Added. Nothing to do in
>         this function as far as i can tell.
>         (shouldFillGap): Implemented. Gap should always be filled.
>         (shouldRotateTabRuns): Implemented. Tabs are not rotated
>         in Metal. False is always returned.
>         (calculateMaxTabHeight): Implemented to call super.
>         (getTabLabelShiftX): Implemented.
>         (getTabLabelShiftY): Implemented.
>         (getTabRunOverlay): Implemented.
>         (paint): Implemented to call super.
>         (paintContentBorderBottomEdge): Likewise.
>         (paintContentBorderLeftEdge): Likewise.
>         (paintContentBorderRightEdge): Likewise.
>         (paintContentBorderTopEdge): Likewise.
>         (paintFocusIndicator): Likewise.
>         (update): Likewise. Should not work any differently from
>         default implementation.
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches





reply via email to

[Prev in Thread] Current Thread [Next in Thread]