Re: [cp-patches] Patch: MetalTabbedPaneUI missing functions

[Lillian Angel]

I removed those functions that BasicTabbedPaneUI already implemented.
I fixed the implementation for those other functions. The highlight was
not being fully drawn on tabs, so I re-implemented
paintHighlightBelowTab. I am pretty sure shouldFillGap should return
false in this case. By running the swing demo with Sun, it doesn't seem
like the gap is ever filled.


2005-11-23  Lillian Angel  <address@hidden>

        * javax/swing/plaf/metal/MetalLookAndFeel.java
        (initComponentDefaults): Added defaults for menu arrow icon,
        menu item arrow icon and menu item check icon.
        * javax/swing/plaf/metal/MetalTabbedPaneUI.java:
        Added new field to store graphics when painting highlight.
        (paintTopTabBorder): Added code to fill gap if it should be
        filled.
        (paintBottomTabBorder): Likewise.
        (paintTabBackground): Added call to paint the highlight below 
        the tab.
        (getColorForGap): Added code to return selected color, if 
        selected.
        (shouldFillGap): Changed to return false. With JDK, gap is 
        never filled in MetalL&F.
        (paintHighlightBelowTab): Implemented to paint the highlight on 
        selected tabs.
        (calculateMaxTabHeight): Removed.
        (getTabLabelShiftX): Removed.
        (getTabLabelShiftY): Removed.
        (getTabRunOverlay): Removed.
        (paint): Removed.
        (paintContentBorderBottomEdge): Removed.
        (paintContentBorderLeftEdge): Removed.
        (paintContentBorderRightEdge): Removed.
        (paintContentBorderTopEdge): Removed.
        (paintFocusIndicator): Removed.
        (update): Removed.

On Wed, 2005-11-23 at 10:26 -0500, Lillian Angel wrote:
> On Wed, 2005-11-23 at 11:40 +0100, Roman Kennke wrote:
> > Hi there,
> > 
> > Am Dienstag, den 22.11.2005, 23:14 -0500 schrieb Thomas Fitzsimmons:
> > > On Tue, 2005-11-22 at 16:10 -0500, Lillian Angel wrote:
> > > > Added missing functions in MetalTabbedPaneUI. Again, most just call
> > > > super.
> > > 
> > > If these methods just call super then there's no reason to override
> > > them.
> > 
> > I agree.
> > 
> > >   I'm surprised that JAPI is marking these as missing since they
> > > are implemented in the base classes.
> > 
> > JAPI didn't mark the methods that are implemented in the base class.
> > JAPI marked only the methods, that are new in MetalTabbedPaneUI.
> 
> My mistake for adding those functions in. I will remove them. The new
> ones that JAPI pointed out, I implemented. I will look into them and see
> if more needs to be done. Otherwise, I will leave them as is.
> 
> >  For
> > these methods it would make sense to figure out how they are supposed to
> > be called and implement that. Otherwise a subclass that overrides these
> > methods won't get the desired functionality.
> 
> 
> Lillian
> 
> 
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

patch.diff
Description: Text Data