[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] FYI: Added some real functionality to SystemFlavorMap
From: |
Jan Röhrich |
Subject: |
Re: [cp-patches] FYI: Added some real functionality to SystemFlavorMap |
Date: |
Wed, 30 Nov 2005 02:03:45 +0100 |
> Jan> oh, I didn't know that these method invocations are faster. But I prefer
> Jan> a more generalized code style. Ok it's a private field so this may be no
> Jan> problem in this case.
> Jan> But are there any other opinions on that or is this somewhere defined in
> Jan> a GNU/Classpath Code style?
>
> AFAIK it isn't a defined style.
>
> I have a slight preference for the more specific declaration. For
> private fields (and local variables) this doesn't hurt clarity or
> maintainability, particularly if you do future refactorings with a
> tool like eclipse. And, it provides a small performance benefit.
Ok, I changed that together with some minor codestyle fixes in the
following patch:
2005-11-30 Jan Roehrich <address@hidden>
* java/awt/datatransfer/SystemFlavorMap.java
Some minor codestyle fixes.
(nativeToFlavorMap): removed generalization.
(flavorToNativeMap): likewise.
patch.diff
Description: Text Data
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil