Re: [cp-patches] FYI: javax.swing.text cleanup

[Anthony Balkissoon]

On Wed, 2005-10-19 at 14:58 +0000, Roman Kennke wrote:
> Some cleanup for javax.swing.text.
> 
> 2005-10-19  Roman Kennke  <address@hidden>
> 
>         * javax/swing/text/AbstractDocument.java
>         * javax/swing/text/AttributeSet.java
>         * javax/swing/text/ComponentView.java
>         * javax/swing/text/DefaultCaret.java
>         * javax/swing/text/DefaultEditorKit.java
>         * javax/swing/text/DefaultHighlighter.java
>         * javax/swing/text/EditorKit.java
>         * javax/swing/text/FieldView.java
>         * javax/swing/text/FlowView.java
>         * javax/swing/text/GlyphView.java
>         * javax/swing/text/JTextComponent.java
>         * javax/swing/text/LayoutQueue.java
>         * javax/swing/text/PlainView.java
>         * javax/swing/text/Segment.java
>         * javax/swing/text/StyledDocument.java
>         * javax/swing/text/html/HTMLEditorKit.java
>         * javax/swing/text/html/HTMLFrameHyperlinkEvent.java
>         * javax/swing/text/html/parser/DocumentParser.java
>         Reformatted slightly. Filled emtpy blocks with comments. Fixed
> some
>         slight API doc errors. Removed some unneeded imports.
> 
> /Roman

The changes to PlainView were more than just reformatting and docs, and
were regressions that were then fixed on November 24 (message
attached).  

Please keep the functional changes separate from reformatting patches.

--Tony

--- Begin Message --- Subject: [cp-patches] FYI: PasswordView and PlainView fixes Date: Thu, 24 Nov 2005 20:38:31 +0000

This patch fixes the PasswordView, so that the caret gets positioned
correctly. The model->view mapping was previously done by the
superclass, which provides a mapping based on the real content. However,
the PasswordView needs to base this mapping on the echo character.

Also I did some small cleanups in PlainView.

2005-11-24  Roman Kennke  <address@hidden>

        * javax/swing/text/PasswordView.java
        (modelToView): Overridden to correctly map between model and view
        respecting the echo character.
        (viewToModel): Added FIXME to show that this method also needs
        to be adjusted like the above method.
        * javax/swing/text/PlainView.java
        (paint): Don't set the font here. This is already done in the
        text component's JComponent.getComponentGraphics() method.
        (damageLineRange): Only repaint the damaged rectangle.

/Roman

patch.diff
Description: Text Data

_______________________________________________
Classpath-patches mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/classpath-patches

--- End Message ---