Re: [cp-patches] GNU Crypto and Jessie merge

[Thomas Fitzsimmons]

On Sat, 2006-01-07 at 10:22 +1100, Raif S. Naffah wrote:
> hello,
> 
> On Saturday 07 January 2006 08:30, Thomas Fitzsimmons wrote:
> > On Sun, 2005-12-25 at 17:06 -0800, Casey Marshall wrote:
> > > Hi,
> > >
> > > I've moved GNU Crypto and Jessie into my Classpath tree,
> > > approximately as I proposed to do earlier. The patch to Classpath,
> > > and a tarball of all the new files, are available from
> > > <http://metastatic.org/source/gnu-crypto-jessie.patch> and
> > > <http://metastatic.org/source/gnu-crypto-jessie.tar.gz>. This
> > > patch/tarball:
> > >
> > >   - Adds GNU Crypto and Jessie under the packages gnu.javax.crypto
> > > and gnu.javax.net.ssl.
> > >   - Adds a `--disable-crypto' switch to configure, and based on
> > > that, uses either `standard.omit' (the default) or `no-crypto.omit'
> > > (which omits crypto providers).
> > >   - Updates `classpath.security' to add the new providers.
> > >
> > > Also, Jessie has been modified to use Classpath's debug logging
> > > mechanism, instead of printing to stderr, and it uses java.util.zip
> > > instead of jzlib. The SSL provider seems to work for me, at least
> > > as a client; I'll try a few more tests before I check it in.
> > >
> > > Does this otherwise look OK to commit? I know some have expressed
> > > concern over including crypto in Classpath, and wanted to know if
> > > the configure switch will suffice for them.
> >
> > Hi,
> >
> > Thanks so much for doing this merge!  It was a nice Christmas
> > present. :-)
> >
> > I'm testing this patch in my GCJ HEAD/Classpath HEAD tree. 
> > Specifically I'm testing Eclipse's extssh mode.  Jsch is still having
> > some problems though.  First it couldn't find the DiffieHellman
> > KeyAgreement algorithm.  I noticed the patch contains this change to
> > gnu/java/security/provider/Gnu.java:
> >
> > -        // KeyAgreement
> > -        put("KeyAgreement.DiffieHellman",
> > gnu.javax.crypto.DiffieHellmanImpl.class.getName()); -       
> > put("Alg.Alias.KeyAgreement.DH", "DiffieHellman");
> >
> > Re-adding those lines fixed the first failure.
> >
> > Then it seems that Jsch requires other algorithms:
> >
> > java.security.NoSuchAlgorithmException: DESede/CBC/NoPadding: DESede
> > updatekeys: java.security.NoSuchAlgorithmException: HmacMD5
> >
> > Are these aliases for algorithms that GNU Crypto already implements
> > or are they missing?
> 
> sounds like your VM is not installing the additional Providers: 
> GnuSecurity and GnuCrypto.  the patch includes a modification to the 
> classpath.security resource file to add the above.  check that the 
> classpath.security file used by your VM includes the following lines:
> 
> security.provider.1=gnu.java.security.provider.Gnu
> security.provider.2=gnu.javax.crypto.jce.GnuCrypto
> security.provider.3=gnu.javax.crypto.jce.GnuSecurity

Ugh, I thought the patch contained the new files so I only applied it.
That would explain some, maybe all of my problems.  I'm rebuilding now.

Thanks,
Tom