[cp-patches] Re: FYI: Some more net regression fixes

[Mark Wielaard]

Hi,

On Thu, 2006-01-12 at 12:56 +0100, Mark Wielaard wrote:
> On Thu, 2006-01-12 at 11:35 +0100, Mark Wielaard wrote:
> > There are only 2 regressions left which I still need to investigate:
> > 
> > -PASS: gnu.testlet.java.net.DatagramPacket.DatagramPacketReceive2:
> > DatagramPacket receive Test B errorCount=0 (number 1)
> > +FAIL: gnu.testlet.java.net.DatagramPacket.DatagramPacketReceive2:
> > DatagramPacket receive Test B errorCount=15 (number 1)
> 
> Found this one. DatagramPacket has a getLength() method that should be
> used to determine how much bytes we want.
> 
> 2006-01-12  Mark Wielaard  <address@hidden>
> 
>     * vm/reference/gnu/java/net/VMPlainDatagramSocketImpl.java
>     (receive): Use packet.getLength().
>     * native/jni/java-net/gnu_java_net_VMPlainDatagramSocketImpl.c
>     (nativeReceive): Check whether the receiver wants zero bytes.
> 
> It also accounts for the somewhat strange situation where someone
> explicitly doesn't want to receive no bytes (although I am not sure that
> actually happens in real code, it looks like something that only happens
> in regression suites).

This turned out to introduce a new regression in
gnu.testlet.java.net.DatagramPacket.DatagramPacketReceive :(
This test expects to be able to reuse a DatagramPacket and get a new
large packet even after receiving a packet with a length smaller then
the original length and without resetting length...

It seems these tests cannot both be right.
Opinions?

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part