classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: Make VMPlainSocketImpl.connect() throw UnknownHostExce


From: Mark Wielaard
Subject: [cp-patches] FYI: Make VMPlainSocketImpl.connect() throw UnknownHostException
Date: Thu, 12 Jan 2006 14:40:25 +0100

Hi,

While hacking in the train I noticed that connect() was throwing an
IllegalArgumentException instead of an UnknownHostException when a name
couldn't be resolved before connecting. Fixed as follows:

2006-01-12  Mark Wielaard  <address@hidden>

        * vm/reference/gnu/java/net/VMPlainSocketImpl.java (connect):
        Throw UnknowHostException when name could not be resolved.

Committed,

Mark


Index: vm/reference/gnu/java/net/VMPlainSocketImpl.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/vm/reference/gnu/java/net/VMPlainSocketImpl.java,v
retrieving revision 1.2
diff -u -r1.2 VMPlainSocketImpl.java
--- vm/reference/gnu/java/net/VMPlainSocketImpl.java    12 Jan 2006 10:36:00 
-0000      1.2
+++ vm/reference/gnu/java/net/VMPlainSocketImpl.java    12 Jan 2006 13:40:12 
-0000
@@ -44,6 +44,7 @@
 import java.net.SocketException;
 import java.net.SocketImpl;
 import java.net.SocketOptions;
+import java.net.UnknownHostException;
 
 import gnu.classpath.Configuration;
 
@@ -279,7 +280,7 @@
     InetAddress addr = sockAddr.getAddress();
 
     if (addr == null)
-      throw new IllegalArgumentException("address is unresolved: " + sockAddr);
+      throw new UnknownHostException(sockAddr.getHostName());
 
     int port = sockAddr.getPort();
 

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]