Re: [cp-patches] RFC: gnu.regexp fix to allow "([(])"

[Mark Wielaard]

Hi Ito,

On Wed, 2006-01-11 at 01:08 +0900, Ito Kazumitsu wrote:
> This fixes the bug #22802.
> 
> ChangeLog:
> 2006-01-10  Ito Kazumitsu  <address@hidden>
> 
>       Fixes bug #22802
>       * gnu/regexp/RE.java(initialize): Fixed the parsing of
>       character classes within a subexpression.

This introduces a few Mauve failures:

+FAIL: gnu.testlet.java.util.regex.CharacterClasses: testMatchComplete
'[[]' flags 0 (number 5)
+FAIL: gnu.testlet.java.util.regex.CharacterClasses: testComplete '[[]'
flags 0 (reset) (number 5)
+FAIL: gnu.testlet.java.util.regex.CharacterClasses: testMatchComplete
'[^[]' flags 0 (number 5)
+FAIL: gnu.testlet.java.util.regex.CharacterClasses: testComplete '[^[]'
flags 0 (reset) (number 5)

Could you take a look at those?

I did check in the following patch to chain the REException so it is
more clear where this is coming from:

2005-01-13  Mark Wielaard  <address@hidden>

        * java/util/regex/Pattern.java (Pattern): Chain REException.

Cheers,

Mark

diff -u -r1.13 Pattern.java
--- java/util/regex/Pattern.java        2 Jul 2005 20:32:44 -0000
1.13
+++ java/util/regex/Pattern.java        13 Jan 2006 09:45:10 -0000
@@ -103,8 +103,11 @@
       }
     catch (REException e)
       {
-       throw new PatternSyntaxException(e.getMessage(),
+       PatternSyntaxException pse;
+       pse = new PatternSyntaxException(e.getMessage(),
                                         regex, e.getPosition());
+       pse.initCause(e);
+       throw pse;
       }
   }

signature.asc
Description: This is a digitally signed message part