classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Classpath java/applet/Applet.java minor documentation patch


From: Eric Blake
Subject: Re: Classpath java/applet/Applet.java minor documentation patch
Date: Wed, 17 Sep 2003 18:00:28 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

Hmm - our HACKING file ought to be updated to show the preferred patch submission method. At any rate, Classpath and gcj are closely tied together, so the best patch submissions just follow the instructions found on http://gcc.gnu.org/contribute.html (with any modifications appropriate for the Classpath directory):

"If you are accessing the CVS repository at gcc.gnu.org, use "cvs update; cvs diff -c3p"; else, use "diff -c3p OLD NEW" or "diff -up OLD NEW". If your version of diff does not support these options, then get the latest version of GNU diff. Patches against current development (mainline CVS) are preferred to patches against releases, unless your patch is intended as a candidate for the release branch."

At any rate, doc patches are appreciated, and you may want to consider sending a group of them (instead of one email per file changed) since they are all related. Also, don't forget Changelog entries. Welcome to Classpath hacking!

Ricky Clarkson wrote:

Hi,

I was idly browsing the Applet.java code and found a slight discrepancy.

Please find attached the file 'diff', which is the result of diff
<original Applet.java> <my Applet.java>, and the file 'diff_minus_u',
which is the result of diff -u <original Applet.java> <my Applet.java>
and please let me know whether you prefer diff or diff -u for patches.

Regards,

Ricky.


------------------------------------------------------------------------

127c127
<    * @return the URL of the document this applet is embedded in
---

  * @return the basename URL of the document this applet is embedded in


------------------------------------------------------------------------

--- classpath/java/applet/Applet.java   2002-05-06 03:43:17.000000000 +0100
+++ Applet.java 2003-09-16 18:53:18.000000000 +0100
@@ -124,7 +124,7 @@
   * Returns the basename URL of the document this applet is embedded in. This
   * is everything up to the final '/'.
   *
-   * @return the URL of the document this applet is embedded in
+   * @return the basename URL of the document this applet is embedded in
   * @see #getCodeBase()
   */
  public URL getDocumentBase()

--
Someday, I might put a cute statement here.

Eric Blake             address@hidden





reply via email to

[Prev in Thread] Current Thread [Next in Thread]