commit-womb
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [commit-womb] gnumaint/rec gnupackages2txt.awk


From: Ineiev
Subject: Re: [commit-womb] gnumaint/rec gnupackages2txt.awk
Date: Sat, 25 Aug 2018 02:31:40 -0400
User-agent: Mutt/1.5.21 (2010-09-15)

Hi, Mike;

On Fri, Aug 24, 2018 at 06:57:14PM -0400, Mike Gerwitz wrote:
> On Wed, Aug 22, 2018 at 08:26:02 -0400, Ineiev wrote:
> >  #  Copyright (C) 2018 Mike Gerwitz
> 
> Be sure to add a Copyright line for yourself as well!

The change is 5 lines long, I don't think it's copyrightable.

> > @@ -26,6 +26,12 @@
> >  }
> >  
> >  {
> > +    if ( ( substr( $1, 1, 1 ) == "+" ) && ( key != "" ) ) {
> > +        # next line of a multiline record
> > +        sub( /^[+] */, "", $0 )
> > +        add_key( key, $0 )
> > +        next
> > +    }
> >      key   = is_key() ? $1 : ""
> >      value = $2
> >  }
> 
> Was the only instance of this the ncurses package?

Yes.

> Was this causing a problem with HTML output?

Yes. the additional line wasn't added to the note and showed up elsewhere.

> No need to change it, but this is another way to make the same change:
> 
>     /^+/ && key {

Indeed, this would be better.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]