Re: [PATCH] Support for --size in du

[Likai Liu]

I don't have access to a FreeBSD system, but I found this thread that mentions the du threshold option.

http://lists.freebsd.org/pipermail/freebsd-hackers/2010-February/030581.html

Like Padraig mentioned, the -t option is more like the --size option proposed before, where + means --min-size, and - means --max-size. What about implementing the -t option like that just for the sake of BSD compatibility, but also implement the --max-size and --min-size options for the sake of better readability?

liulk

On Sat, Jan 19, 2013 at 5:47 PM, Bernhard Voelker <address@hidden> wrote:

On 01/17/2013 03:58 PM, Pádraig Brady wrote:
> I Just noticed another option from BSD:
>
> -t threshold
>       Display only entries for which size exceeds threshold.  If
>       threshold is negative, display only entries for which size is
>       less than the absolute value of threshold.
>
> I slightly prefer --min-size and --max-size,
> though not at the expense of losing the opportunity
> to increase compat between these tools.
>
> I suppose we could rename --size to --threshold too.

It seems there are many ways - like always. ;-)

I think --min-size/--max-size has a functional plus over one
single new option. But increasing compatibility to BSD is tempting.

If I'd be asked to decide between --size and --threshold then
the latter is the winner: a) BSD compat, b) the abbreviation
of the option better fits into the already existing ones,
see --size vs. --si, while --th is (currently) fine.

I'll change the patch towards --threshold then. WDYT?

Have a nice day,
Berny