Re: [PATCH] Support for --size in du

[Pádraig Brady]

On 01/21/2013 12:46 AM, Bernhard Voelker wrote:
> On 01/20/2013 11:55 AM, Pádraig Brady wrote:
> > On 01/19/2013 10:47 PM, Bernhard Voelker wrote:
> > > [...]But increasing compatibility to BSD is tempting.
>
> Just FYI: it seems that only FreeBSD's du supports
> the -t option (but not the long --threshold) while
> OpenBSD does not:
>
> FreeBSD:
>    http://www.freebsd.org/cgi/man.cgi?query=du
>    https://github.com/freebsd/freebsd/blob/master/usr.bin/du/du.c
> OpenBSD:
>    http://www.openbsd.org/cgi-bin/man.cgi?query=du
>    http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/du/du.c
>
> > > If I'd be asked to decide between --size and --threshold then
> > > the latter is the winner: a) BSD compat, b) the abbreviation
> > > of the option better fits into the already existing ones,
> > > see --size vs. --si, while --th is (currently) fine.
> > >
> > > I'll change the patch towards --threshold then. WDYT?
> >
> > +1
>
> Thanks. Here it is.
>
> I did not alias --threshold to a short -t option ... as I
> remembered that we should be reluctant to add short options
> which are not officially standardised.

Yes, but in this case -t is already used in FreeBSD,
so by adding that, we gain compatibility with it.
So in this case I'd be inclined to add the -t alias.

thanks,
Pádraig.