Re: tests/du/slink.sh: what's the rationale?

[Bernhard Voelker]

On 01/20/2013 01:34 PM, Pádraig Brady wrote:
> On 01/20/2013 12:31 PM, Bernhard Voelker wrote:
>> On 01/20/2013 12:01 PM, Pádraig Brady wrote:
>>> On 01/19/2013 10:33 PM, Bernhard Voelker wrote:
>>>> Is tests/du/slink.sh obsolete nowadays?
>>
>> That test is problematic with various file systems, and the original
>> test case is already covered by other tests. I'd tend to simply
>> remove it.
> 
> +1


>From 8e33c96c68aae6bcd1e97e76d1cb56ea08dc4428 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <address@hidden>
Date: Sun, 20 Jan 2013 13:54:55 +0100
Subject: [PATCH] maint: remove test case du/slink

This test tried to prove that the size of a symlink must be
greater than Zero, and it used to do this by working on symlinks
to long file names.  This assumption is dependant on the under-
lying file system, and in some environments like XEN does not
even work on file systems known to work otherwise.

The test for dereferencing and no-dereferencing symlinks is
already covered by other tests (du/deref.sh, du/deref-args.sh,
and du/no-deref.sh).  Therefore, remove it.

* tests/du/slink.sh: Remove file.
* tests/local.mk (all_tests): Remove the above test.

Discussed in:
http://lists.gnu.org/archive/html/coreutils/2013-01/msg00053.html
---
 tests/du/slink.sh |   46 ----------------------------------------------
 tests/local.mk    |    1 -
 2 files changed, 0 insertions(+), 47 deletions(-)
 delete mode 100755 tests/du/slink.sh

diff --git a/tests/du/slink.sh b/tests/du/slink.sh
deleted file mode 100755
index 85697bc..0000000
--- a/tests/du/slink.sh
+++ /dev/null
@@ -1,46 +0,0 @@
-#!/bin/sh
-# Ensure that the size of a long-named-symlink is > 0.
-
-# Copyright (C) 2002-2013 Free Software Foundation, Inc.
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
-print_ver_ du
-
-# Determine if '.' is on a local (would non-NFS be sufficient?) file system.
-# At least on OSF/1 4.0d, when using an nfsv3 file system,
-# each created symlink can end up having a size of 0.
-require_local_dir_
-
-if df --type=xfs . >/dev/null 2>&1; then
-  # At least on Irix-6.5.19, when using an xfs file system,
-  # each created symlink (name lengths up to 255) would have a size of '0'.
-  skip_ "'.' is on an XFS file system"
-fi
-
-symlink_name_lengths='1 15 16 31 32 59 60 63 64 127 128 255 256 511 512 1024'
-for len in $symlink_name_lengths; do
-  name=$(seq 1 $len|tr -c x y |head -c$len)
-  # Record the names of symlinks that are successfully created.
-  ln -fs $name $len > /dev/null 2>&1 \
-    && symlinks="$symlinks $len"
-done
-
-du -a $symlinks > out || fail=1
-
-# Require that at least one of these symlinks has a non-zero size.
-grep '^[1-9]' out > /dev/null || fail=1
-
-Exit $fail
diff --git a/tests/local.mk b/tests/local.mk
index 2fe006d..02d1c08 100644
--- a/tests/local.mk
+++ b/tests/local.mk
@@ -497,7 +497,6 @@ all_tests =                                 \
   tests/du/one-file-system.sh                  \
   tests/du/restore-wd.sh                       \
   tests/du/slash.sh                            \
-  tests/du/slink.sh                            \
   tests/du/trailing-slash.sh                   \
   tests/du/two-args.sh                         \
   tests/id/gnu-zero-uids.sh                    \
-- 
1.7.7