coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests/du/slink.sh: what's the rationale?


From: Jim Meyering
Subject: Re: tests/du/slink.sh: what's the rationale?
Date: Sun, 20 Jan 2013 22:15:30 +0100

Pádraig Brady wrote:

> On 01/20/2013 12:58 PM, Bernhard Voelker wrote:
>> On 01/20/2013 01:34 PM, Pádraig Brady wrote:
>>> On 01/20/2013 12:31 PM, Bernhard Voelker wrote:
>>>> On 01/20/2013 12:01 PM, Pádraig Brady wrote:
>>>>> On 01/19/2013 10:33 PM, Bernhard Voelker wrote:
>>>>>> Is tests/du/slink.sh obsolete nowadays?
>>>>
>>>> That test is problematic with various file systems, and the original
>>>> test case is already covered by other tests. I'd tend to simply
>>>> remove it.
>>>
>>> +1

For the record, it was trying to ensure that not all symlinks
(across all file system types) have zero size.

Removing that test sounds fine to me, too.
FYI, here's the ChangeLog entry for the addition of that file:

    * tests/du/Makefile.am (TESTS): Add slink.
    * tests/du/slink: New test for system.h change of 2002-08-31.

Which refers to this commit:

    commit 62808a7fb5cbb2d321719c0cba558f2ce8c90d24
    Author: Jim Meyering <address@hidden>
    Date:   Sat Aug 31 16:04:57 2002 +0000

    Symlinks were always reported as using 0 blocks.

    (ST_NBLOCKS): Don't depend on file type.
    This reverts the change of 2000-01-30.
    Based on a report and patch from Neil Brown via Michael Stone.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]