Re: [Denemo-devel] Initial Clef - Transposing: How do I ... / Why does Denemo...

[Jeremiah Benham]

On Fri, 2008-07-25 at 16:44 +0100, Richard Shann wrote:
> On Fri, 2008-07-25 at 10:08 -0500, Jeremiah Benham wrote:
> > 
> > > The code as it stands has a bug, you cannot re-set transposition to
> > 0
> > 
> > I fixed this and pushed it to git. 
> ????
> > It was that the input was being
> > stored as double instead of in integer. 
> %d is not a double, it is an int (all float arguments to functions are
> actually passed as double, so %f means double even if the thing written
> is a float, as it is automatically promoted to double). I've never
> noticed %i before as far as I can remember 

Thanks for the clarification. If you have the second edition of K&R its
defined on page 154. 
Quote:
d, i | int; decimal number.

I noticed on scanf i and d differ. I am not sure if this relates to why
the value is allowed to set to 0 or not. I would have to look at the
code of g_string_sprintf. This function has been labeled as obsolete
anyway according to this website:

http://library.gnome.org/devel/glib/unstable/glib-Strings.html#g-string-sprintf

Jeremiah

Jeremiah



> - it is not in Kernigan &
> Ritchie which is still on my desk! It seems to be a synonym for %d which
> is traditional C, it would be best to revert this change, as it will
> have people reaching for the reference manual to find out what it means.
> > I change a few of the others
> > that should be stored in integer also. When testing I noticed volume
> > does not go to 0 also. This is a small bug but users will not be able
> > to
> > mute parts if it can't be set to 0. That is if exportmidi even notices
> > the volume property. I agree that the staff properties dialog needs to
> > be rewritten after the release. 
> > 
> > Jeremiah 
> > 
> > 
> > > once it has been set to anything else. I have pushed this change to
> > git. 
> 
> ??? as you can see, I pushed the change to git before emailing about it
> 
> And can we agree a code freeze now for the release? It means no change
> to the repository unless a serious bug shows up (if in doubt, we should
> consult)?
> Then we should post up the tarball & .deb, apply a label or tag or
> whatever git does and after a day or so for people to download and test
> the tarball & .deb we should announce the release. Meanwhile, we should
> collect together release notes. It looks like the windows build will be
> hampered by not being able to spawn processes :-( but there is a
> workaround.
> 
> Richard
> 
>