Re: [Denemo-devel] Updating POTFILES.in

[Richard Shann]

On Thu, 2013-12-12 at 09:47 +0100, Eloi Rivard wrote:
> Le jeudi 12 décembre 2013 à 08:35 +0000, Richard Shann a écrit :
> > Eloi - 
> > 
> > I notice that you have had to commit a change to POTFILES.in because I
> > added a new command.
> > 
> > diff --git a/po/POTFILES.in b/po/POTFILES.in
> > > 
> > > index a4300e1..fe8c08e 100644 (file)
> > > 
> > > 
> > > --- a/po/POTFILES.in
> > > +++ b/po/POTFILES.in
> > > @@ -476,6 +476,8 @@
> > actions/menus/MainMenu/NavigationMenu/Cursor/ToggleCursorHighlight.scm
> > >
> > actions/menus/MainMenu/NavigationMenu/Cursor/ToggleCursorHighlight.xml
> > >  actions/menus/MainMenu/NavigationMenu/DenemoLink.scm
> > >  actions/menus/MainMenu/NavigationMenu/DenemoLink.xml
> > >
> > +actions/menus/MainMenu/NavigationMenu/MIDI/CursorToMarkedMidiNotePosition.scm
> > >
> > +actions/menus/MainMenu/NavigationMenu/MIDI/CursorToMarkedMidiNotePosition.xml
> > 
> > 
> > Is this change a hand-written one or the result of some make command?
> > Adding commands is something I do very often, so it needs to be as
> > foolproof as reasonably possible. I think the steps are thus
> > 
> > Create the command (if you are not using Denemo to do this, then this
> > step is create <command>.scm <command>.xml and write an entry in
> > Default.commands using values from <command>.xml)
> > git add <command>.scm <command>.xml
> > ...some further step for POTFILES.in
> > 
> > I guess this needs to be documented on the Maintainer page (this page
> > could be linked to from the Development menu I think).
> > 
> > Richard
> 
> It is done by running "make potfile", and it should be done every time a
> command is added or deleted, else "make check" and "make distcheck" will
> fail. 
> 
> For some reasons, I could not get it automatized and passing "make
> distcheck" test. If it does not bother you, you can run 'make potfile'
> when you add a command.

It's good there is a make command for it - I just need to get the
procedure into my fingertips so that I don't break things. I always do
make and make install and execute the binary before checking in. I could
do make check too, I shall try to remember this.

Richard