|
From: | Don Ward |
Subject: | Re: [Discuss-gnuradio] Build failure - caused by posix_memalign.cc- in trunk built under Cygwin |
Date: | Tue, 17 Feb 2009 11:13:33 -0500 |
----- Original Message ----- From: "Michael Dickens" <address@hidden>
To: "Don Ward" <address@hidden> Cc: "Prior-Jones, Michael R" <address@hidden>; <address@hidden> Sent: Tuesday, February 17, 2009 10:38 AMSubject: Re: [Discuss-gnuradio] Build failure - caused by posix_memalign.cc- in trunk built under Cygwin
On Feb 17, 2009, at 10:22 AM, Don Ward wrote:/usr/include/cygwin/stdlib.h references valloc(), but valloc() is declared in /usr/include/malloc.h. So <malloc.h> is what you want to include for Cygwin.Isn't <malloc.h> what was added in the first place to posix_memalign.cc, which caused this issue?
No. What caused the issue is that valloc is not defined in the standard place (<stdlib.h>) on Cygwin; <malloc.h> was added to fix the problem on Cygwin, but it caused problems on other platforms.
I'm good with adding in malloc.h into configure.ac, then into posix_memalign.cc with proper #ifdef around it. That will work with OSX, and won't hurt Linux, and sounds like it'll allow Cygwin to work. Eric / Johnathan ... comments? These are small / easy changes. - MLD
This sounds good to me as long as there is no hazard in including <malloc.h> on other (non-Cygwin) systems that have it but don't need it.
-- Don W.
[Prev in Thread] | Current Thread | [Next in Thread] |