Re: [Discuss-gnuradio] Win32 and gr-blocks/lib/stream_pdu_base.cc

[Gisle Vanem]

Josh Blum wrote:

> On 10/05/2014 04:25 AM, Gisle Vanem wrote:
> > Since my previous message seems to be ignored, here is something simpler
> > for you to comment on.
> >
> > In gr-blocks/lib/stream_pdu_base.cc, the read() and write() functions
> > are used on sockets. This doesn't work well on Windows as you're
> > probably aware. A simple fix is to has something like this at the top of
> > this file:
> >
> > #ifdef WIN32
> >   #undef read
> >   #undef write
> >   #define read(sk,buf,len) ::recv (sk, (char*)(buf), len, 0)
> >   #define write(sk,buf,len) ::send (sk, (const char*)(buf), len, 0)
> > #endif

...

> Ideally we could switch the code to call send/recv, and the tuntap would
> continue working -- this needs testing.
>
> Your patch is pretty good too, because it doesnt interfere with existing
> functionality, and the tuntap is ifdefed out on windows.

Just a note on this (my almost 1 year old email). Seems there are no Windows
users of GnuRadio that needs to play with sockets.

I did a "git pull" just now and saw to my dismay that this issue (with using
read() + write() on sockets) is still present. According to github, the last
change of this (relevant to Winsock) file was on 5 March 2013!


--gv