Re: [PATCH]: GWorkspace Icon Themability

[Enrico Sersale]

On 2004-10-30 22:53:44 +0300 Alex Perez <aperez@student.santarosa.edu> wrote:

> Uli Kusterer wrote:
> > In article <mailman.6154.1099144155.2017.discuss-gnustep@gnu.org>,
> >     Alex Perez <aperez@student.santarosa.edu> wrote:
> > > - (void)createIcons
> > > {
> > > -  ASSIGN (hostIcon, [NSImage imageNamed: @"common_Root_PC.tiff"]);
> > > -  ASSIGN (folderIcon, [NSImage imageNamed: @"folder.tiff"]);
> > > -  ASSIGN (toolIcon, [NSImage imageNamed: @"tool.tiff"]);
> > > -  ASSIGN (unknownIcon, [NSImage imageNamed: @"unknown.tiff"]);
> > > +  ASSIGN (hostIcon,    [NSImage _standardImageWithName: @"Root_PC.tiff"]);
> > > +  ASSIGN (folderIcon,  [NSImage imageNamed: @"folder.tiff"]);
> > > +  ASSIGN (toolIcon,    [NSImage imageNamed: @"tool.tiff"]);
> > > +  ASSIGN (unknownIcon, [NSImage imageNamed @"unknown.tiff"]);
> > > }
> >
> > I'm not Enrico, but does the above mean that none of these icons except for 
> > Root_PC will be themeable? If these are app-specific icons, I guess that's 
> > okay, but if folder.tiff is a regular folder icon, I'd say it's missing a 
> > _standardIconWithName: call.
>
> This is actually an area that I actually already have an e-mail in my drafts 
> folder about, for Enrico. He's using some non-standard folder icons in 
> GWorkspace and I was going to ask him if there was a reason for that, because 
> it seems to me that it really ought to be using the system-wide alternatives 
> (Folder.tiff, UnknownTool.tiff, and Unknown.tiff instead)

This -createIcons method is in GWNet, an app that don't use the NSWorkspace's 
-iconForFile method because its icons represent files on a ftp or smb server.

But it is true that I'm almost accustomed to use non-standard icons even where I could 
use the standard ones. This is a mistake but it cames from the fact that I *must* provide 
anyway some specific icons with GWorkspace. The problem - that neither the proposed patch 
nor the other solutions solve - is that an object that represents a directory can have 
also a "open" state and its icon must reflect this; so, GW has *its* 
open-folder icon; but this causes, anyway, a incongruity with the standard folder icon 
(and with any icon you can use). On my system, I solve this changing the system icon with 
an icon from the same family (it is also nicier).
The conclusion is that some icons should be added to the actual set; they are:

- the open folder icon
- the disk icon used on the desktop
- the icon for a "open" disk (as for the folder)
- the empty recycler icon
- the full recycler icon