Code review [Was: GNA is down...}

[Fred Kiefer]

On 13.02.2012 22:09, Eric Wasylishen wrote:
> One big advantage of dvcs's, which is something I don't hear
> discussed a lot, is how much better the GUI's are for reviewing
> recent commits made by other people. In my opinion, every active
> developer should be reviewing the diffs of most commits to their
> project. It's simply too slow for me to deal with in subversion (look
> up the revision number, run svn diff -rRevisionBeforeFoo:foo | vim -,
> wait several seconds, read the diff, look up the next rev # I want to
> read, repeat…). Is everyone else reviewing most diffs of recent
> commits? My bet is people aren't reviewing as much as they could
> because it's slow with subversion.

I try to do a code review of all changes to gui and back. I do this by 
clicking on the links send to the GNUstep-cvs mailing list. (For example 
http://svn.gna.org/viewcvs/gnustep?rev=34741&view=rev)
Surely not the fastest way to do a code review, but I can do it even 
when travelling from an internet cafe or my iPad.
What ever new DVCS we come up with it should be able to send similar 
mails. Or it will increase the work load.