Re: address@hidden (Pavel Janík)] Re: crash in emacs-21.1

[Eli Zaretskii]

> From: address@hidden (Gerd Moellmann)
> Date: 30 Oct 2001 14:19:00 +0100
> 
> Kenichi Handa <address@hidden> writes:
> 
> > Thank you!  With this, I found a bug in read1 (in lread.c).
> > It was me who introduced this bug.  :-(
> 
> The only way not to make mistakes is to do nothing at all :-).

Indeed.

> I think this copes with the buffer reallocation, but the reallocation
> isn't triggered with the elc files, and the result is identical to
> what it was before (same backtrace etc.).
[...]
> + static void
> + to_multibyte (p, end, nchars)
> +      char **p, **end;
> +      int *nchars;
> + {
> +   int nbytes;
> + 
> +   parse_str_as_multibyte (read_buffer, *p - read_buffer, &nbytes, nchars);
> +   if (nbytes > read_buffer_size)

Shouldn't the last line be sonmething like

  if (nbytes > nchars)

?